Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State instanceid context #182

Merged
merged 18 commits into from
Nov 27, 2023
Merged

State instanceid context #182

merged 18 commits into from
Nov 27, 2023

Conversation

kristoferjoseph
Copy link
Contributor

Adds documentation of context and instanceID to state docs

ryanbethel
ryanbethel approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ryanbethel ryanbethel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

colepeters
colepeters reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@colepeters colepeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Left a few suggestions that are pretty much just grammar stuffs ;)

app/docs/md/elements/state/context.md Outdated Show resolved Hide resolved
app/docs/md/elements/state/context.md Outdated Show resolved Hide resolved
app/docs/md/elements/state/context.md Outdated Show resolved Hide resolved
app/docs/md/elements/state/context.md Outdated Show resolved Hide resolved
app/docs/md/elements/state/context.md Outdated Show resolved Hide resolved
app/docs/md/elements/state/index.md Outdated Show resolved Hide resolved
macdonst
macdonst approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@macdonst macdonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two comments which shouldn't block anything.

app/docs/md/elements/state/index.md Outdated Show resolved Hide resolved
app/docs/md/elements/state/instance-id.md Show resolved Hide resolved
@kristoferjoseph kristoferjoseph merged commit eab309e into main Nov 27, 2023
4 checks passed
@kristoferjoseph kristoferjoseph deleted the state-instanceid-context branch November 27, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colepeters colepeters colepeters left review comments

@ryanbethel ryanbethel ryanbethel approved these changes

@macdonst macdonst macdonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristoferjoseph @macdonst @colepeters @ryanbethel